-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(repo): Add bearer authentication method for support various git hosting platform #7571
base: main
Are you sure you want to change the base?
feat(repo): Add bearer authentication method for support various git hosting platform #7571
Conversation
In #6833, it looks like the user wants to add support for Bitbucket. What if just adding
|
When I initially submitted the PR, I focused only on bearer authentication for Bitbucket, which is why I implemented it that way. According to the official document, adding only Additionally, it seems we cannot use a fixed git username when user use AWS CodeCommit repository. Should I create a separate discussion to address this or add commit to review? |
Thanks for sharing the doc. Doesn't Bitbucket accept basic authentication with a bearer token? Did you see if the current implementation worked with Bitbucket?
|
I think I might have missed some parts of the test. After reproducing the environment again, I confirmed that specifying the username is necessary. I’m not sure if my approach is 100% correct, but I made to allow specifying the username by I planned to split the implementation into tokenauth and basicauth as before. |
I would also love to have support for bitbucket repositories. Is there any update regarding it? |
@knqyf263 Is there any additional feedback or thoughts on this PR? |
Hello @bunseokbot @teixeira-fernando Hi, We have been busy with other more important issues lately. |
It looks like the repository access token can be used with the fixed user name |
It seems that using In the Bitbucket Data Center version, only username is specified, so I configured it to retrieve the username value using the In the same way, if the user is using the Bitbucket Cloud version, it seems possible to resolve this by setting 'x-token-auth' in the |
Then, it's better to add a new CLI flag rather than the env. |
Description
This PR adds support for the bearer authentication method while pull git repository.
Related issues
Checklist